Generalize to work on EBCDIC systems #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging this, I found it more convenient to use the more modern is() which tells you how something is wrong, not just that something is wrong. Both are available in Test::More, used by the test file.
This commit causes this module to pass all its tests on EBCDIC, which core Perl supports. Further, it allows other modules shipped with the Perl distribution to also work on EBCDIC. Basically, all the commit does is to remove underlying assumptions of the bit patterns for various characters, instead using mnemonics, or functions furnished by core that hide the details. Some of the tests were converted to use a character, U+00B6, that works on both character sets, instead of the ones previously used, which appear to have been arbitrarily chosen.
|
Thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl once again works on EBCDIC platforms, but JSON::PP doesn't. These patches remedy this, and hence also fix some other modules shipped with the Perl core that rely on J:P