Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force decoupled tabs #174

Closed
makmic opened this issue Jul 7, 2021 · 0 comments · Fixed by #175
Closed

Force decoupled tabs #174

makmic opened this issue Jul 7, 2021 · 0 comments · Fixed by #175

Comments

@makmic
Copy link
Member

makmic commented Jul 7, 2021

he implementaiton of I open a new tab` currently looks like this:

  page.execute_script "window.open('#{relative_target_path}', '_blank')"

I recently debugged a failing test to this very step, as the newly opened tab was somehow "connected" to the previous tab (chrome only).
Changing the code fixed the issue for me:

  page.execute_script "window.open('#{relative_target_path}', '_blank', 'noopener')"

Opening a window of the same domain with window.open seems to be the same as middle-clicking the refresh button (thus cloning the session). I think this is never intended when using this step. I'd suggest simply adding the 'noopener' attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant