Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Then show me the page" should support capybara-screenshot #81

Closed
foobear opened this issue Aug 31, 2018 · 0 comments
Closed

"Then show me the page" should support capybara-screenshot #81

foobear opened this issue Aug 31, 2018 · 0 comments

Comments

@foobear
Copy link
Member

foobear commented Aug 31, 2018

As mentioned in #50, Then show me the page depends on a method defined by the launchy gem.

We do not want to add launchy as a dependency, but use it, if available. In addition, we use capybara-screenshot in recent projects and want the step to support its screenshot_and_save_page, too.

I recommend we make show me the page detect if either is available and use its way to create a snapshot, or fail with a helpful error message if neither is available.

Method documentation / Readme should be updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant