Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors in devices/goodcell_ev_charger.yaml #1808

Closed
urbanbur opened this issue Apr 9, 2024 · 0 comments
Closed

errors in devices/goodcell_ev_charger.yaml #1808

urbanbur opened this issue Apr 9, 2024 · 0 comments

Comments

@urbanbur
Copy link

urbanbur commented Apr 9, 2024

There are a few errors in devices/goodcell_ev_charger.yaml configuration:

Sensors Voltage L2 and Voltage L3 are missing parameter
mapping:
- scale: 10

Sensors of class: energy should not be 'measurement' but 'total_increasing' for aggregate (integrative) values.

I attach a corrected yaml file.
goodcell_ev_charger.zip
@urbanbur urbanbur added the bug Something isn't working label Apr 9, 2024
@make-all make-all added device improvement Improvement to an existing device config and removed bug Something isn't working labels Apr 9, 2024
make-all added a commit that referenced this issue Apr 9, 2024
@make-all
Goodcell EV charger: correct scale and state class of some sensors.
a8396b9 
- Voltages L2 and L3 should be scaled like L1
- energy sensor requires state class of total_increasing, not measurement

Issue #1808
@make-all make-all added awaiting confirmation Wating for confirmation the issue is solved unreleased Will be in next release labels Apr 9, 2024
@make-all make-all removed awaiting confirmation Wating for confirmation the issue is solved unreleased Will be in next release device improvement Improvement to an existing device config labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tuya Local
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@make-all @urbanbur