Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename zx_db11b_doorbell_alarm.yaml to zx_db11b_doorbell_a… #1761

Closed
wants to merge 1 commit into from
Closed

Update and rename zx_db11b_doorbell_alarm.yaml to zx_db11b_doorbell_a… #1761

wants to merge 1 commit into from

Conversation

salvin-nl
Copy link

…larm2.yaml

@make-all
Copy link
Owner

Renaming config files after they ship is a breaking change, and there does not seem to be any reason for it.
I also don't see the rationale for renaming the product to another non-brand name, and making a base64 value available as a sensor.

@make-all make-all closed this Mar 21, 2024
@salvin-nl
Copy link
Author

Hi, I'm trying to add base64 sensor, so that i can differentiate between different types of devices being used. modifying binary sensor to sensor is giving a list of sensors, that is helpful in identifying which calling button is pressed

make-all added a commit that referenced this pull request Mar 25, 2024
@make-all
ZX-DB11 doorbells: correct ringing type, add attribute to read it
0ae409a 
- ZX-DB11 and ZX-DB11B appear to be essentially the same and should
  probably be merged.
- the original report included base64 (raw) type for alarm, but it was
  missed when adding the device, and later when requested it was
  mistakenly made a boolean. Since this is optional, and only appears
  when actually ringing, this was not detected, and the mapping covers
  the issue.  Later a user submitted a PR for the DB11B which copied
  this mistake.

Based on PR #1761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salvin-nl @make-all