Bump S3G to master #85
Conversation
| @@ -34,9 +34,14 @@ | |||
| port = options.port | |||
| factory = makerbot_driver.MachineFactory() | |||
| obj = factory.build_from_port(port) | |||
| profile = getattr(obj, 'profile') | |||
There was a problem hiding this comment.
Try obj.profile here instead.
|
It doesn't look like this pull request has been merged yet ? Is there a particular hold up ? The newer s3g revision also includes the updated USB device IDs for newer revision MakerBot Replicator 2 models. Without the new device IDs the MachineDetector in s3g can't find and print to the device :-( |
|
@awk Whoa didn't know that! I think we had a few issues with this that we didn't solve. Currently our make-me install is down as we move offices, but once we're moved I'll see what I can do to get this running. Have you tried out this branch? Were there any issues you noticed? |
|
I'm hoping to grab the branch/patch and try it later today - I'll report back any issues (though my testing is likely to be 'light') |
|
I did a brief test with a build from the support-gcode-variables branch. I had two issues :
The changes to print_gcode.py are pretty straightforward - would you like a new issue and a pull request for the support-gcode-variables branch with the fixes ? |
|
@awk That'd be great. Target this branch instead of master 👍 |
|
OK - I'm on vacation for a bit - it'll be about a week and I'll do the Pull Request |
|
🤘 No worries. Enjoy your vacation. Sorry it took me so long to get back to you! |
Bumps s3g to master and also handles the added variables in their start gcode.