Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate examples to used named methods #14

Closed
aoberoi opened this issue May 9, 2021 · 0 comments · Fixed by #158
Closed

Migrate examples to used named methods #14

aoberoi opened this issue May 9, 2021 · 0 comments · Fixed by #158
Labels
enhancement New feature or request examples Issues related to `examples`

Comments

@aoberoi
Copy link
Contributor

aoberoi commented May 9, 2021

Depends on #5, #13

Currently, the examples are using the request() method to make requests. These calls should be replaced with calls to named methods on the client, such as pages.create().
@aoberoi aoberoi added enhancement New feature or request examples Issues related to `examples` labels May 15, 2021
@chazkiker2 chazkiker2 mentioned this issue Jun 14, 2021
Closed
5 tasks
@lao9 lao9 mentioned this issue Jul 21, 2021
Merged
@lao9 lao9 closed this as completed in #158 Jul 23, 2021
lao9 added a commit that referenced this issue Jul 23, 2021
@lao9
[examples] test and improve glitch examples (#158)
5c612c5 
Was not really up to normal Notion code quality, did not use the notion client as one would expect, and there were some issues with the existing script.

Closes #14
Closes #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request examples Issues related to `examples`
Projects
None yet
Milestone
No milestone
1 participant
@aoberoi