Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading blocks do not have the is_toggleable property in their types #420

Closed
huw opened this issue Jul 9, 2023 · 1 comment · Fixed by #438
Closed

Heading blocks do not have the is_toggleable property in their types #420

huw opened this issue Jul 9, 2023 · 1 comment · Fixed by #438

Comments

@huw
Copy link
Contributor

huw commented Jul 9, 2023

The specification says that heading_1, heading_2, and heading_3 blocks should have an is_toggleable property within the heading_x property. I have verified against the API that it is reporting this data correctly (and therefore returning it through the client), but it is not typed correctly in the library.

While it is present inside BlockObjectRequest, BlockObjectRequestWithoutChildren, UpdateBlockBodyParameters, it is not present inside BlockObjectResponse (specifically Heading1BlockObjectResponse, Heading2BlockObjectResponse, and Heading3BlockObjectResponse). I’d normally submit a PR but I’m aware that api-endpoints.ts is auto-generated; I’ve patched the library for my own usage.

This is somewhat related to #245, although I believe @aalemayhu was using a version of the API before the is_toggleable property was included in the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants