Ignore VS Code settings directory #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rhart92
added a commit
that referenced
this pull request
Oct 3, 2023
Co-authored-by: Ryan Hart <ryan@makenotion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the
.vscodedirectory can be ignored. We already have.cspell.jsonin our project and they support.cspell.jsonas the configuration file in VS Code:See https://github.com/streetsidesoftware/vscode-spell-checker/blob/add7ae9b37b7d02eadfbd2788ab0b0d6699e09d6/packages/client/src/settings/CSpellSettings.ts#L11-L13.
On the other hand, ignoring the
.vscodedirectory can let developers put their editor settings. They can decide to enable or disable specific extension settings for specific projects.Currently, we don't have other editor settings like
.vscode/launch.json,.vscode/tasks.json, etc. So it's OK to ignore the whole directory.We could change the rule if we need to put some other project-level configuration files in the
.vscodedirectory in the future.