Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypeScript for recheck NPM package #145

Closed
makenowjust opened this issue Nov 23, 2021 · 0 comments · Fixed by #149
Closed

Use TypeScript for recheck NPM package #145

makenowjust opened this issue Nov 23, 2021 · 0 comments · Fixed by #149
Assignees
@makenowjust

Comments

@makenowjust
Copy link
Contributor

makenowjust commented Nov 23, 2021 •
edited
Loading

What is the problem?

Currently recheck NPM package is written in usual JavaScript without statically type checking.

Static type checking is an important method to reduce bugs in a project.
We want to adopt this, and TypeScript is the best tool for type checking in JavaScript today.

How to fix the problem?

Three steps.

  1. Rewrite the package source code in TypeScript.
  2. Fix esbuild settings to transpile TypeScript.
  3. Add a type checking workflow job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makenowjust makenowjust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite recheck package in TypeScript makenowjust-labs/recheck
1 participant
@makenowjust