Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert duration params to integer explicitly on playground #501

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

makenowjust
Copy link
Contributor

Fixed #500

Changes

  • Convert duration params to integer explicitly on the playground. Because HTML <input> values are string.

@makenowjust makenowjust added the misc Misc label Jun 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #501 (ffe3e95) into main (656a747) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #501   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         2756      2756           
  Branches       245       245           
=========================================
  Hits          2756      2756           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656a747...ffe3e95. Read the comment docs.

@makenowjust makenowjust merged commit 843661c into main Jun 23, 2022
@makenowjust makenowjust deleted the params-to-int branch June 23, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Misc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters don't work on the playground
2 participants