Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against QGIS, GDAL #744

Merged
merged 19 commits into from
Jan 21, 2023
Merged

Test against QGIS, GDAL #744

merged 19 commits into from
Jan 21, 2023

Conversation

thuydotm
Copy link
Contributor

@thuydotm thuydotm commented Dec 16, 2022

To evaluate the reliability of xarray-spatial, let's test the package and compare the results against QGIS/GDAL.

  • aspect
  • slope
  • multispectral tools
  • proximity
  • zonal stats

Fixes #22, #104, #182

@thuydotm thuydotm added the WIP Work in progress label Dec 16, 2022
@tcmetzger tcmetzger linked an issue Dec 16, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Base: 79.87% // Head: 79.89% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (99b8db9) compared to base (f6c5164).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
+ Coverage   79.87%   79.89%   +0.02%     
==========================================
  Files          19       19              
  Lines        4169     4169              
==========================================
+ Hits         3330     3331       +1     
+ Misses        839      838       -1     
Impacted Files Coverage Δ
xrspatial/utils.py 63.01% <0.00%> (-1.37%) ⬇️
xrspatial/proximity.py 97.99% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thuydotm thuydotm added ready to merge PR is ready to merge and removed WIP Work in progress labels Jan 5, 2023
Copy link
Contributor

@brendancol brendancol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great approach and let's continue follow up PRs on additional QGIS or other baseline checks.

@brendancol brendancol merged commit 3df3ec7 into master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Multispectral tools against QGIS Assess Quality of Existing Tools
3 participants