Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setuptools #749

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Use setuptools #749

merged 2 commits into from
Jan 5, 2023

Conversation

giancastro
Copy link
Contributor

No description provided.

@giancastro giancastro added the WIP Work in progress label Jan 4, 2023
@giancastro giancastro removed the WIP Work in progress label Jan 4, 2023
@giancastro
Copy link
Contributor Author

@thuydotm , this PR fixes #741. I had to remove the codebase tests, so we will need to add flake8 and isort to Github Actions.

@giancastro
Copy link
Contributor Author

@thuydotm , we also need to test if xrspatial.__version__ will work fine when installing from pypi and conda forge.

@thuydotm
Copy link
Contributor

thuydotm commented Jan 5, 2023

Thanks Gian! I can see all the jobs have run successfully. Going to merge this to have the build system work. Any idea why it suddenly failed before?

@thuydotm thuydotm merged commit f6c5164 into master Jan 5, 2023
@giancastro
Copy link
Contributor Author

No, I wasn't able to know the reason.

@giancastro giancastro deleted the giancastro/build-system branch January 5, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thuydotm thuydotm thuydotm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giancastro @thuydotm