Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zonal_crosstab 3D: Ensure content of input param values is preserved #754

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

thuydotm
Copy link
Contributor

Fixes #751

@thuydotm thuydotm added the WIP Work in progress label Jan 10, 2023
@thuydotm thuydotm self-assigned this Jan 10, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 79.87% // Head: 79.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (363457d) compared to base (f6c5164).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   79.87%   79.88%           
=======================================
  Files          19       19           
  Lines        4169     4170    +1     
=======================================
+ Hits         3330     3331    +1     
  Misses        839      839           
Impacted Files Coverage Δ
xrspatial/zonal.py 85.47% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brendancol
Copy link
Contributor

brendancol commented Jan 11, 2023

@thuydotm

  • Add test case to test_zonal to make sure input values remain unmodified

@thuydotm thuydotm merged commit af42544 into master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D zonal crosstab changes content of input paramvalues
3 participants