Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readthedocs configuration [WIP] #798

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Update readthedocs configuration [WIP] #798

merged 6 commits into from
Apr 23, 2024

Conversation

tcmetzger
Copy link
Collaborator

Follow-up to #797

@tcmetzger tcmetzger added the WIP Work in progress label Apr 23, 2024
@tcmetzger tcmetzger changed the title Update readthedocs configuration Update readthedocs configuration [WIP] Apr 23, 2024
@tcmetzger
Copy link
Collaborator Author

Turns out the extra_requirements config parameter (https://docs.readthedocs.io/en/stable/config-file/v2.html#packages) on readthedocs currently isn't working properly, so I added a pre_build step instead. This way, readthedocs are now able to install the docs dependencies defined in setup.cfg.

@tcmetzger tcmetzger merged commit 1ea028e into master Apr 23, 2024
12 checks passed
@tcmetzger tcmetzger deleted the update_readthedocs_config branch April 23, 2024 15:53
@tcmetzger tcmetzger mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendancol brendancol brendancol approved these changes

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tcmetzger @brendancol