Skip to content

Commit

Permalink
fix: cycles n+1 (#1689)
Browse files Browse the repository at this point in the history
  • Loading branch information
pablohashescobar committed Jul 27, 2023
1 parent c54b8b9 commit c947a6d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion apiserver/plane/api/serializers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
)
from .state import StateSerializer, StateLiteSerializer
from .view import IssueViewSerializer, IssueViewFavoriteSerializer
from .cycle import CycleSerializer, CycleIssueSerializer, CycleFavoriteSerializer
from .cycle import CycleSerializer, CycleIssueSerializer, CycleFavoriteSerializer, CycleWriteSerializer
from .asset import FileAssetSerializer
from .issue import (
IssueCreateSerializer,
Expand Down
6 changes: 6 additions & 0 deletions apiserver/plane/api/serializers/cycle.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
from .project import ProjectLiteSerializer
from plane.db.models import Cycle, CycleIssue, CycleFavorite

class CycleWriteSerializer(BaseSerializer):

class Meta:
model = Cycle
fields = "__all__"


class CycleSerializer(BaseSerializer):
owned_by = UserLiteSerializer(read_only=True)
Expand Down
4 changes: 2 additions & 2 deletions apiserver/plane/api/views/cycle.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
CycleIssueSerializer,
CycleFavoriteSerializer,
IssueStateSerializer,
CycleWriteSerializer,
)
from plane.api.permissions import ProjectEntityPermission
from plane.db.models import (
Expand Down Expand Up @@ -338,7 +339,7 @@ def partial_update(self, request, slug, project_id, pk):
status=status.HTTP_400_BAD_REQUEST,
)

serializer = CycleSerializer(cycle, data=request.data, partial=True)
serializer = CycleWriteSerializer(cycle, data=request.data, partial=True)
if serializer.is_valid():
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
Expand Down Expand Up @@ -691,7 +692,6 @@ def post(self, request, slug, project_id):
return Response(
{
"error": "You have a cycle already on the given dates, if you want to create your draft cycle you can do that by removing dates",
"cycles": CycleSerializer(cycles, many=True).data,
"status": False,
}
)
Expand Down

0 comments on commit c947a6d

Please sign in to comment.