[WEB-1632] fix: validating and showing proper alert estimate point ha…

…s to be taken greater than 0 in create and update (#4850) * fix: validating and showing proper alert estimate point has to be taken greater than 0 in create and update * fix: updating the number point validation
makeplane · Jun 18, 2024 · d3d723c · d3d723c
1 parent 6828d33
commit d3d723c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/web/core/components/estimates/points/create.tsx b/web/core/components/estimates/points/create.tsx
@@ -82,8 +82,14 @@ export const EstimatePointCreate: FC<TEstimatePointCreate> = observer((props) =>
 
       if (!isRepeated) {
         if (currentEstimateType && [(EEstimateSystem.TIME, EEstimateSystem.POINTS)].includes(currentEstimateType)) {
-          if (estimateInputValue && Number(estimateInputValue) && Number(estimateInputValue) >= 0) {
-            isEstimateValid = true;
+          if (estimateInputValue && !isNaN(Number(estimateInputValue))) {
+            if (Number(estimateInputValue) <= 0) {
+              handleEstimatePointError &&
+                handleEstimatePointError(estimateInputValue, "Estimate point should be greater than 0.");
+              return;
+            } else {
+              isEstimateValid = true;
+            }
           }
         } else if (currentEstimateType && currentEstimateType === EEstimateSystem.CATEGORIES) {
           if (estimateInputValue && estimateInputValue.length > 0 && isNaN(Number(estimateInputValue))) {

diff --git a/web/core/components/estimates/points/update.tsx b/web/core/components/estimates/points/update.tsx
@@ -87,8 +87,14 @@ export const EstimatePointUpdate: FC<TEstimatePointUpdate> = observer((props) =>
 
       if (!isRepeated) {
         if (currentEstimateType && [(EEstimateSystem.TIME, EEstimateSystem.POINTS)].includes(currentEstimateType)) {
-          if (estimateInputValue && Number(estimateInputValue) && Number(estimateInputValue) >= 0) {
-            isEstimateValid = true;
+          if (estimateInputValue && !isNaN(Number(estimateInputValue))) {
+            if (Number(estimateInputValue) <= 0) {
+              handleEstimatePointError &&
+                handleEstimatePointError(estimateInputValue, "Estimate point should be greater than 0.");
+              return;
+            } else {
+              isEstimateValid = true;
+            }
           }
         } else if (currentEstimateType && currentEstimateType === EEstimateSystem.CATEGORIES) {
           if (estimateInputValue && estimateInputValue.length > 0 && isNaN(Number(estimateInputValue))) {