fix: link validation fix #1645
Merged
fix: link validation fix #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaryan610
reviewed
Jul 24, 2023
| @@ -12,7 +12,7 @@ type Props = { | |||
| created_by: string; | |||
| created_by_detail: IUserLite; | |||
| metadata: any; | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/services/issues.service.ts
Outdated
| @@ -437,7 +437,7 @@ class ProjectIssuesServices extends APIService { | |||
| issueId: string, | |||
| data: { | |||
| metadata: any; | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/services/modules.service.ts
Outdated
| @@ -198,7 +198,7 @@ class ProjectIssuesServices extends APIService { | |||
| moduleId: string, | |||
| data: { | |||
| metadata: any; | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/types/issues.d.ts
Outdated
| @@ -62,7 +62,7 @@ export interface IIssueParent { | |||
| } | |||
|
|
|||
| export interface IIssueLink { | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/types/issues.d.ts
Outdated
| @@ -96,7 +96,7 @@ export interface IIssue { | |||
| created_by_detail: IUserLite; | |||
| id: string; | |||
| metadata: any; | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/types/modules.d.ts
Outdated
| @@ -32,7 +32,7 @@ export interface IModule { | |||
| created_by_detail: IUserLite; | |||
| id: string; | |||
| metadata: any; | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
aaryan610
reviewed
Jul 24, 2023
apps/app/types/modules.d.ts
Outdated
| @@ -74,7 +74,7 @@ export interface ModuleIssueResponse { | |||
| } | |||
|
|
|||
| export type ModuleLink = { | |||
| title: string; | |||
| title: string | null; | |||
There was a problem hiding this comment.
The title cannot be null, it can be an empty string.
dakshesh14
approved these changes
Jul 25, 2023
pablohashescobar
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: