fix: Removing dependency on tiptap pro extension #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
@henit-chobisa please look into removing it from our DevOps and self hosting pipelines 🙌 |
henit-chobisa
force-pushed
the
remove-tiptap-pro-extension
branch
from
e1fec90
to
d2c7a75
Compare
|
Updated setup script and github actions. |
sriramveeraghanta
approved these changes
Sep 19, 2023
This was referenced Dec 14, 2023
Palanikannan1437
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
The Tiptap token was used only for downloading an extension that previously "enabled" us to manage image deletions efficiently so that s3 storage is cleaned up properly if an image gets deleted in the editor, but now we're using the source from s3 to detect this instead since with the new approach I figured out a way to do that.
Here's a PR that got us one step forward toward that by removing the dependency #2092