chore: layout refactor #2532
Merged
chore: layout refactor #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
sriramveeraghanta
requested changes
Oct 25, 2023
| className?: string; | ||
| }; | ||
|
|
||
| export const ProfileAuthWrapper = (props: Props) => ( |
There was a problem hiding this comment.
Merge this function with you below layout function.
There was a problem hiding this comment.
Remove app layout from here.
sriramveeraghanta
requested changes
Oct 25, 2023
| // layouts | ||
| import { ProfileAuthWrapper } from "layouts/profile-layout"; | ||
| import { AppLayout } from "layouts/app-layout"; | ||
| import { ProfileAuthWrapper } from "layouts/profile-layout/layout"; |
There was a problem hiding this comment.
import from index file.
| @@ -7,8 +7,10 @@ import useSWR from "swr"; | |||
| // services | |||
| import { UserService } from "services/user.service"; | |||
| // layouts | |||
| import { ProfileAuthWrapper } from "layouts/profile-layout"; | |||
| import { AppLayout } from "layouts/app-layout"; | |||
| import { ProfileAuthWrapper } from "layouts/profile-layout/layout"; | |||
There was a problem hiding this comment.
import from index file
| @@ -7,6 +7,7 @@ import useSWR, { mutate } from "swr"; | |||
| // services | |||
| import { ProjectService } from "services/project"; | |||
| // layouts | |||
| import { AppLayout } from "layouts/app-layout"; | |||
| import { ProjectSettingLayout } from "layouts/setting-layout/project-setting-layout"; | |||
There was a problem hiding this comment.
import from index file
plane-bot
approved these changes
Oct 25, 2023
sriramveeraghanta
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: