Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: keyboard shortcuts modal #2822

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Nov 21, 2023

This PR focuses on revamping the keyboard shortcuts modal

Improvements-

  1. Updated the modal UI.
  2. Updated the search logic to substring matching.
  3. Refactored the code.
Screen.Recording.2023-11-27.at.5.52.48.PM.mov

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane-sh 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 0:33am
plane-staging 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 0:33am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:33am
plane-dev ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:33am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:33am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:33am

@aaryan610 aaryan610 marked this pull request as ready for review November 27, 2023 12:25
@sriramveeraghanta sriramveeraghanta merged commit 10c52bf into develop Nov 27, 2023
10 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the refactor/shortcuts_modal branch November 27, 2023 13:12
sriramveeraghanta pushed a commit that referenced this pull request Dec 7, 2023
* refactor: keyboard shortcuts modal

* chore: updated search logic

* refactor: divided the modal component into granular components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants