Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cycle & module sidebar date range picker #3127

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Dec 14, 2023

Problems related to cycle/module sidebar:

  1. The date range picker (in both the cycle & module sidebar) was showing the range with the current date if the start/end date was not selected.
  2. The local state date before updating to API, was not shown in the sidebar.
  3. The date range picker (in both the cycle & module sidebar) hover cursor was cursor-default.
  4. The lead/member select popover in the module sidebar, hover cursor was cursor-default.
  5. The lead/member select popover in the module sidebar, can be accessible by viewer/guest.

Solution:

  1. Now, showing range only when either the start/end date is defined.
  2. Now, rendering the local state date as soon as we select any date, with the help of form data.
  3. Changed the cursor-default to cursor-pointer.
  4. Changed the cursor-default to cursor-pointer.
  5. Checked the current user role, and disabled it for the viewer/guest role.
sidebar-date_range-picker-problem.mp4
sidebar-date_range_picker-solution.mp4

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:50am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:50am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:50am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:50am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:50am

@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 14, 2023 10:30
@sriramveeraghanta sriramveeraghanta merged commit 1c546e3 into develop Dec 14, 2023
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/cycle_sidebar_date_picker branch December 14, 2023 11:01
@1akhanBaheti 1akhanBaheti added this to the 0.14.1-dev milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants