Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: estimates and issue parent id fixes #3188

Merged
merged 2 commits into from Dec 27, 2023
Merged

chore: estimates and issue parent id fixes #3188

merged 2 commits into from Dec 27, 2023

Conversation

NarayanBavisetti
Copy link
Collaborator

@NarayanBavisetti NarayanBavisetti commented Dec 19, 2023 •
edited by 1akhanBaheti

This PR resolves the following issues:

Backend:

  • Implemented a validation for estimate points, limiting the value to a maximum of 20 characters.
  • Enforced that the sequence ID accepts only whole numbers, excluding decimals (in the search endpoint).
  • Included a validation to verify the issue's parent ID.

Frontend:

  • Added validation while creating/updating estimates, if estimate point characters are more than 20 characters, then toast will be shown with this message: Estimate point cannot have more than 20 characters.

@NarayanBavisetti NarayanBavisetti added 🐛bug Something isn't working ⚙️backend labels Dec 19, 2023
@NarayanBavisetti NarayanBavisetti added this to the 0.14.2-dev milestone Dec 19, 2023
@NarayanBavisetti NarayanBavisetti marked this pull request as draft December 19, 2023 08:30
@sriramveeraghanta sriramveeraghanta modified the milestones: 0.14.2-dev, v0.15-dev Dec 19, 2023
@sriramveeraghanta sriramveeraghanta changed the base branch from release-0.14.2 to release-0.15 December 19, 2023 13:50
@NarayanBavisetti NarayanBavisetti changed the title chore: validations and bug fixes chore: estimates and issue parent id fixes Dec 19, 2023
Base automatically changed from release-0.15 to preview December 22, 2023 12:49
@NarayanBavisetti NarayanBavisetti marked this pull request as ready for review December 26, 2023 12:18
@sriramveeraghanta sriramveeraghanta changed the base branch from preview to develop December 27, 2023 10:05
@sriramveeraghanta sriramveeraghanta merged commit 78428fb into develop Dec 27, 2023
1 of 5 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/validations branch December 27, 2023 10:05
@rhea0110 rhea0110 mentioned this pull request Dec 29, 2023
Merged
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@NarayanBavisetti @1akhanBaheti @sriramveeraghanta
chore: estimates and issue parent id fixes (#3188)
968d0fb 
* chore: validations and bug fixes

* chore: estimate point character limit validation

---------

Co-authored-by: LAKHAN BAHETI <lakhanbaheti9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees
No one assigned
Labels
⚙️backend 🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.14.2-dev
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NarayanBavisetti @sriramveeraghanta @1akhanBaheti