Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keyboard navigation spreadsheet layout for issues #3564

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

rahulramesha
Copy link
Collaborator

This PR enables Keyboard navigation for spreadsheet layout. The changes include,

  • A base navigation logic that contains most of arrows base navigation
  • Adding class clickable to the buttons inside table cells that are clickable
  • Logic to focus back from dropdowns back to the table cell on pressing esc
  • Adding TabIndex to few components to prevent it to be navigable
spreadsheet.keyboard.navigation.mov

@rahulramesha rahulramesha added 🌟enhancement New feature or request 🌐frontend labels Feb 5, 2024
@rahulramesha rahulramesha added this to the v0.16 milestone Feb 5, 2024
@sriramveeraghanta sriramveeraghanta merged commit fb3dd77 into develop Feb 8, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the feat/spreadsheet-keyboard-navigation branch February 8, 2024 06:19
aaryan610 pushed a commit that referenced this pull request Feb 8, 2024
* enable keyboard navigation for spreadsheet layout

* move the logic to table level instead of cell level

* fix perf issue that made it unusable

* fix scroll issue with navigation

* fix build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟enhancement New feature or request 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants