Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-474]: Layout change not working in cycles and modules #3729

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

  1. Layout change is not working in the calendar layout inside cycles and modules.
  2. When clicking on the Today button in the week layout, a week ahead of the current week is being displayed.

Solution:

  1. Fixed update layout handler, the function required cycleId/moduleId as a param which was missing.
  2. Fixed the logic to display all days of the current week, which was always rendering a week ahead of the desired week.

Media:

Screen.Recording.2024-02-21.at.1.52.25.PM.mov

Issues: WEB-473, WEB-474

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Feb 21, 2024
@aaryan610 aaryan610 added this to the v0.16 milestone Feb 21, 2024
@sriramveeraghanta sriramveeraghanta merged commit 3efb7fc into preview Feb 21, 2024
8 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/calendar-layout branch February 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants