Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-586] chore: spreadsheet layout keyboard accessibility #3818

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[WEB-586] chore: spreadsheet layout keyboard accessibility #3818

merged 5 commits into from
Feb 28, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 28, 2024 •
edited
Loading

Improvement:

This PR includes improvements for keyboard accessibility in spreadsheet layout:

  • Focus state management upon closing peek overview.
  • Enabled toggling focus using the Enter key for dropdowns.

Issue link: [WEB-586]

@anmolsinghbhatia anmolsinghbhatia added this to the v0.17.0-dev milestone Feb 28, 2024
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review February 28, 2024 07:35
@sriramveeraghanta sriramveeraghanta merged commit b152078 into develop Feb 28, 2024
7 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/spreadsheet-layout-keyboard-accessibility branch February 28, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@rahulramesha rahulramesha Awaiting requested review from rahulramesha

Assignees
No one assigned
Labels
🌟enhancement New feature or request 🌐frontend 🌟improvement
Projects
None yet
Milestone
v0.17.0-dev
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmolsinghbhatia @sriramveeraghanta