Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-658] fix: multiple toast alerts on adding existing issues #3889

Merged
merged 6 commits into from Mar 6, 2024
Merged

[WEB-658] fix: multiple toast alerts on adding existing issues #3889

merged 6 commits into from Mar 6, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

  1. On adding an existing issue to a completed cycle, both, success and error, toast alerts were getting displayed.

Solution:

  1. Removed the success toast alert.

Media:

Before-

Screen.Recording.2024-03-06.at.6.23.17.PM.mov

After-

Screen.Recording.2024-03-06.at.6.22.29.PM.mov

Plane issue: WEB-658

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Mar 6, 2024
@aaryan610 aaryan610 added this to the v0.17.0-dev milestone Mar 6, 2024
@aaryan610 aaryan610 marked this pull request as draft March 6, 2024 13:06
@aaryan610 aaryan610 marked this pull request as ready for review March 6, 2024 13:27
@sriramveeraghanta sriramveeraghanta merged commit c08d698 into develop Mar 6, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/cycle-add-issue branch March 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.17.0-dev
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaryan610 @sriramveeraghanta