Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-717] fix: delete issue modal UI fixes. #3944

Merged
merged 2 commits into from Mar 12, 2024
Merged

[WEB-717] fix: delete issue modal UI fixes. #3944

merged 2 commits into from Mar 12, 2024

Conversation

prateekshourya29
Copy link
Collaborator

Problems

  1. When the close button within the delete modal popup is clicked, the peek overview gets automatically closed.
  2. When clicking on 'Delete' or 'Archive Issue' to open the modal in the issue details sidebar, the entire sidebar shifts downward.

Solutions

  1. Removed the removeRoutePeekId from the close action of the modal.
  • Before
scrnli_3_12_2024_3-13-26.PM.webm
  • After
scrnli_3_12_2024_3-06-22.PM.webm
  1. Removed the style that was causing the issue.
  • Before
scrnli_3_12_2024_1-52-40.PM.webm
  • After
scrnli_3_12_2024_3-01-09.PM.webm

This PR is liked to WEB-717

@prateekshourya29 prateekshourya29 self-assigned this Mar 12, 2024
@sriramveeraghanta sriramveeraghanta merged commit c97b994 into develop Mar 12, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/issue-delete-modal branch March 12, 2024 13:41
@prateekshourya29 prateekshourya29 added this to the v0.17.0-dev milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@rahulramesha rahulramesha Awaiting requested review from rahulramesha

Assignees

@prateekshourya29 prateekshourya29

Labels
🌐frontend 🎨UI / UX
Projects
None yet
Milestone
v0.17.0-dev
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prateekshourya29 @sriramveeraghanta