Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-738] chore: conditionally render projects in the dropdown #3952

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

aaryan610
Copy link
Collaborator

Problems:

  1. In the create issue, cycle and module modals, all the projects are visible in the projects' dropdown despite the user being a guest/viewer in those projects.
  2. The create cycle, module, view and page modals can be opened using shortcuts even if the user is a guest/viewer in the project.

Solutions:

  1. Conditionally render only those projects in which a user is a member/admin.
  2. Added extra conditions to only trigger the modals if the user is a member/admin in the project, otherwise show a toast alert saying the user doesn't have the permission.

Other improvements:

  1. Refactored the shortcuts logic for better understanding.

Media:

Screen.Recording.2024-03-13.at.12.24.35.PM.mov

Plane issue: WEB-738

@sriramveeraghanta sriramveeraghanta merged commit 861a1c4 into develop Mar 15, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/projects-dropdown branch March 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants