[WEB-1140] chore: Gantt pragmatic dnd #4390
Merged
+385
−433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const sourceElement = document.getElementById(sourceElementId); | ||
| sourceElement?.classList?.add(shouldHighLightWithLine ? HIGHLIGHT_WITH_LINE : HIGHLIGHT_CLASS); | ||
| if (shouldScrollIntoView && sourceElement) | ||
| await scrollIntoView(sourceElement, { behavior: "smooth", block: "center", duration: 1500 }); |
There was a problem hiding this comment.
Isn't 1500ms 2 long for a scroll?
There was a problem hiding this comment.
1500 because, if the list is very long, the duration is high so that it scrolls to the position and does not time out in between
SatishGandham
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-1140
This PR replaces the @hello-pangea-dnd with the new Pragmatic-dnd for Gantt chart.
Screen.Recording.2024-05-07.at.18.32.46.mov