Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1251] chore: view list enhancement #4427

Merged
merged 3 commits into from
May 10, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented May 10, 2024

Changes:

This PR includes the following changes:

  • Moved view list sub header to app header.
  • Added creator avatar in view list item.
  • Refactored code (moved view list search query to MobX)

Issue link: [WEB-1251]

Media:

Before After
before after

@anmolsinghbhatia anmolsinghbhatia self-assigned this May 10, 2024
@anmolsinghbhatia anmolsinghbhatia changed the title chore: view list enhancement [WEB-] chore: view list enhancement May 10, 2024
@anmolsinghbhatia anmolsinghbhatia changed the title [WEB-] chore: view list enhancement [WEB-1251] chore: view list enhancement May 10, 2024
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review May 10, 2024 07:54
if (isSearchOpen && searchQuery.trim() === "") setIsSearchOpen(false);
});

return (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SatishGandham SatishGandham merged commit e396424 into preview May 10, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the chore/view-list-enhancement branch May 10, 2024 09:49
@anmolsinghbhatia anmolsinghbhatia added this to the v0.20-dev milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants