Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1118] fix: table selections using drag handle fixed #4429

Merged
merged 2 commits into from
May 10, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 commented May 10, 2024

Fixes

  1. Selections now occur properly, no matter the level of nesting.
  2. Nesting with Tab for list items inside tables work as intended.
  3. Selection works for all kinds of nodes inside tables (or any nest able node)
  4. Drag behaviour fixed for tables and block-quotes without clicking on it first.

Demo (working with a list inside table inside table inside table....)

Screen.Recording.2024-05-10.at.1.54.20.PM.mov

For eg, this is how GitHub supports nested tables...

ASCII HTML
Single backticks 'Isn't this fun?' 'Isn't this fun?'
Quotes "Isn't this fun?"
ASCII HTML
Single backticks 'Isn't this fun?' ‘Isn’t this fun?’
Quotes "Isn't this fun?" “Isn’t this fun?”
Dashes -- is en-dash, --- is em-dash – is en-dash, — is em-dash
Dashes -- is en-dash, --- is em-dash -- is en-dash, --- is em-dash

We support it too now ;)

Screen.Recording.2024-05-10.at.2.13.11.PM.mov

Additional fixes

  1. toggling an empty codeBlock no longer throws an error defaulting to the default toggleCodeBlock behavior exposed by the tiptap apis.

@Palanikannan1437 Palanikannan1437 self-assigned this May 10, 2024
@Palanikannan1437 Palanikannan1437 changed the title fix: table selections using drag handle fixed [WEB-1118] fix: table selections using drag handle fixed May 10, 2024
@SatishGandham SatishGandham merged commit 0ad8bf7 into preview May 10, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/table-drag-handle-selections branch May 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants