Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-1624] chore: add un-snooze option and minor fixes in inbox issue #4854

Merged
merged 3 commits into from
Jun 18, 2024
Merged

[WEB-1624] chore: add un-snooze option and minor fixes in inbox issue #4854

merged 3 commits into from
Jun 18, 2024

Conversation

prateekshourya29
Copy link
Collaborator

Problems

  1. There was no option to un-snooze an issue if it has been snoozed.
  2. Inbox issue snooze till data was inconsistent on initial load and when we go to issue detail.

Solution

  1. Added option to un-snooze the inbox issue.
  2. This inconsistency was because we were updating the snooze_till property to date object from date string at the store initialization phase.

Media

Screen.Recording.2024-06-18.at.2.15.51.PM.mov

Issue link: WEB-1624 and WEB-1605

@prateekshourya29 prateekshourya29 added this to the v0.22-dev milestone Jun 18, 2024
@prateekshourya29 prateekshourya29 self-assigned this Jun 18, 2024
SatishGandham
SatishGandham requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@SatishGandham SatishGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare with current date when showing snooze and un snooze button

@prateekshourya29 prateekshourya29 marked this pull request as draft June 18, 2024 12:50
@prateekshourya29
Copy link
Collaborator Author

Compare with current date when showing snooze and un snooze button

Done!

@prateekshourya29 prateekshourya29 marked this pull request as ready for review June 18, 2024 13:06
@SatishGandham SatishGandham merged commit 8155d9a into develop Jun 18, 2024
21 of 22 checks passed
@SatishGandham SatishGandham deleted the chore/inbox-snooze branch June 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SatishGandham SatishGandham SatishGandham approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees

@prateekshourya29 prateekshourya29

Labels
🐛bug Something isn't working 🌐frontend 🌟improvement
Projects
None yet
Milestone
v0.22-dev
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prateekshourya29 @SatishGandham