Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1635] style: fix vertical section tabs highlights. #4855

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

prateekshourya29
Copy link
Collaborator

Problem

Active tab highlights is not working for dashboard/ workspace/ project and profile tabs.

Solution

This problem occurred due the the recent changes in next.config file where we added trailingSlash: true in the configuration. But the highlight logic was checking for the URL pathname without that trailing /.

Issue link: WEB-1635

@prateekshourya29 prateekshourya29 marked this pull request as ready for review June 18, 2024 10:46
@SatishGandham SatishGandham merged commit c8736f1 into develop Jun 18, 2024
21 of 22 checks passed
@SatishGandham SatishGandham deleted the style/vertical-tab-highlights branch June 18, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants