fix: OAuth adapter error codes + missing account provider migration that introduces GitLab #4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. |
almereyda
changed the title
|
@almereyda, the migration has been already updated and the above migration is present on migration 0069. You can remove the migration file from the PR. |
|
Thanks for the contribution @almereyda. |
pablohashescobar
merged commit 38fc851
into
makeplane:fix-4897-migration
13 checks passed
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jul 2, 2024
…#5013) * fix: OAuth adapter error codes + missing account provider migration that introduces GitLab (#4998) * feat(apiserver): GitLab OAuth client * feat(admin,packages,space,web): GitLab OAuth client * Feat(apiserver/oauth): authentication_error_code() * chore: remove empty files introduced by rebase * dev: delete migration --------- Co-authored-by: jon ⚝ <jon@allmende.io>
|
Thanks for taking care of this. I remember having had searched the migrations folder for checking if it was included, but maybe it was also very late at night. Looking forward to the release of GitLab support with v0.22! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #4828 on current
previewFixes
_provider_error_code()by introducing the method that is being called further down inoauth.py. Used to deduplicate code inget_user_token()andget_user_response(). Also renames it toauthentication_error_code(), to fit more with where it's output is being used, namely as index forAUTHENTICATION_ERROR_CODES[].This also rediscovered a migration, which wasn't previously included in the merge of #4692 and had back then been auto-generated with running
makemigrationsonce. This alteration seems to be missing from the current tree, why it is included here again, despite not being mentioned in #4897.Closes #4897