Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

remove MDAI and MWETH #227

Merged
merged 4 commits into from
May 26, 2020
Merged

remove MDAI and MWETH #227

merged 4 commits into from
May 26, 2020

Conversation

levity
Copy link
Contributor

@levity levity commented May 1, 2020

just use DAI and WETH now
related to ch183

just use DAI and WETH now
completes ch183
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #227 into dev will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
- Coverage   84.96%   84.94%   -0.02%     
==========================================
  Files         130      130              
  Lines        3812     3807       -5     
==========================================
- Hits         3239     3234       -5     
  Misses        573      573              
Impacted Files Coverage Δ
packages/dai-plugin-mcd/src/Auction.js 100.00% <ø> (ø)
...ions/src/migrations/GlobalSettlementDaiRedeemer.js 14.63% <0.00%> (ø)
packages/dai/src/eth/Currency.js 100.00% <ø> (ø)
packages/dai-plugin-mcd/src/schemas/computed.js 75.20% <50.00%> (ø)
packages/dai-plugin-mcd/src/CdpManager.js 96.85% <100.00%> (ø)
packages/dai-plugin-mcd/src/CdpType.js 94.44% <100.00%> (ø)
packages/dai-plugin-mcd/src/ManagedCdp.js 96.66% <100.00%> (ø)
packages/dai-plugin-mcd/src/SavingsService.js 87.87% <100.00%> (ø)
packages/dai-plugin-mcd/src/SystemDataService.js 100.00% <100.00%> (ø)
packages/dai-plugin-mcd/src/index.js 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a624aca...fcbeec5. Read the comment docs.

@levity
Copy link
Contributor Author

levity commented May 11, 2020

since this touches the migrations plugin, we should:

  • merge plugin changes from the migration dashboard back to dev
  • change the dashboard to use the plugin from this repo via yalc, make sure tests pass
  • switch to this branch, fix dashboard code so tests pass
  • merge these changes to dev and publish a new plugin release
  • change the dashboard code to use the new plugin version, make sure tests pass

@ethanbennett
Copy link
Contributor

@levity has any development been done on the plugin in the monorepo since the split? I don't know of any--it may be easier to simply delete the plugin from here, then drop the directory from the dashboard repo in here, rather than merging the files? There could be conflicts just from keeping the addresses up to date and tests passing

@levity
Copy link
Contributor Author

levity commented May 12, 2020

@levity has any development been done on the plugin in the monorepo since the split? I don't know of any--it may be easier to simply delete the plugin from here, then drop the directory from the dashboard repo in here, rather than merging the files? There could be conflicts just from keeping the addresses up to date and tests passing

well... this PR is development on the plugin... 😅 maybe i jumped the gun on implementing these changes. anyway i can try copying the files over and seeing what the diff looks like

@levity levity merged commit be2fcc8 into dev May 26, 2020
@b-pmcg b-pmcg deleted the no-more-mdai branch April 23, 2021 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants