Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The IFlashMintReceiver callback should use a more generic function name. #132

Closed
alcueca opened this issue Nov 26, 2020 · 1 comment
Closed

The IFlashMintReceiver callback should use a more generic function name. #132

alcueca opened this issue Nov 26, 2020 · 1 comment

Comments

@alcueca
Copy link

alcueca commented Nov 26, 2020

execute is very generic and could clash with functionality on the receiver or on other callback interfaces.

I would recommend using onFlashMint, since the interface will likely be reused by other projects outside MakerDAO.
@alcueca alcueca changed the title The IFlashMintReceiver callback method use a more generic function name. The IFlashMintReceiver callback should use a more generic function name. Nov 26, 2020
@hexonaut
Copy link
Contributor

Thanks for opening these, but it's in the wrong repository.

I've opened a PR to implement this change: makerdao/dss-flash#8

@CPSTL CPSTL closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hexonaut @CPSTL @alcueca