Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIP63 Production Release Changes #720

Merged
merged 3 commits into from Jan 23, 2023
Merged

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Dec 2, 2022

MIP63/MIP63.md Outdated
@@ -77,7 +77,7 @@ The only connection is through `dss-vest`, where Keeper Networks are allocated a

#### Keeper Duties and Expectations

It is expected that Keeper Networks will be able to appropriate stream in their budget to be within the requested buffer min and max values. Any excess DAI beyond the max should be returned to the surplus buffer, and the network should act in a timely manor to replenish DAI if the buffer drops below the min value. If the DAI in the buffer consistently is dropping below the min value then a new application should be submitted to increase the budget.
It is expected that Keeper Networks will be able to appropriate stream in their budget to be within the requested buffer min and max values. Any excess DAI beyond the max should be returned to the surplus buffer, and the network should act in a timely manner to replenish DAI if the buffer drops below the min value. If the DAI in the buffer is consistently running out then a new application should be submitted to increase the budget.
Copy link

@ghost ghost Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a maximum duration for these budget requests. I've suggested 6 months but open to other suggestions.

Suggested change
It is expected that Keeper Networks will be able to appropriate stream in their budget to be within the requested buffer min and max values. Any excess DAI beyond the max should be returned to the surplus buffer, and the network should act in a timely manner to replenish DAI if the buffer drops below the min value. If the DAI in the buffer is consistently running out then a new application should be submitted to increase the budget.
It is expected that Keeper Networks will be able to appropriate stream in their budget to be within the requested buffer min and max values. Any excess DAI beyond the max should be returned to the surplus buffer, and the network should act in a timely manner to replenish DAI if the buffer drops below the min value. If the DAI in the buffer is consistently running out then a new application should be submitted to increase the budget. Budget requests should not exceed a maximum duration of 6 months.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 months is pretty small. Ideally this should eventually be set it and forget it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I'd written 12 months, happy for you to pick an alternative number. The issue with set it and forget it is that it minimizes opportunity for Governance oversight. The act of requesting a budget forces Governance to assess whether the keeper is providing value or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a middle ground we can go with 2 years. This is not the same as a CU where 1 year or less makes sense due to the complex nature of the relationship. Here it is pretty straight forward. They either do their job or not and there is some degree of quality of the work in how fast they execute, how expensive the calls are, etc.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 years sounds good to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@blimpa blimpa merged commit dc920bd into makerdao:master Jan 23, 2023
@blimpa
Copy link
Collaborator

blimpa commented Jan 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants