Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do price rounding better in sai_maker_otc.py #35

Closed
livnev opened this issue Aug 30, 2017 · 1 comment
Closed

Do price rounding better in sai_maker_otc.py #35

livnev opened this issue Aug 30, 2017 · 1 comment
Labels
sai-maker-otc

Comments

@livnev
Copy link
Contributor

livnev commented Aug 30, 2017

Due to precision issues, the price rounding mechanism currently used in sai_maker_otc.py doesn't guarantee that a price will always be displayed with the required number of decimal places (e.g. in the Oasis frontend). It may be preferable to round the quantities as well (but to a different number of digits) in order to achieve a consistent number of decimal places.
@ghost ghost added the sai-maker-otc label Oct 11, 2017
@ghost ghost mentioned this issue Dec 7, 2017
Open
@ghost
Copy link

ghost commented Dec 7, 2017

Moved to makerdao/market-maker-keeper#2. Closing it here.

@ghost ghost closed this as completed Dec 7, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sai-maker-otc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@livnev