Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medianizer storage #155

Merged
merged 27 commits into from
Jun 24, 2020
Merged

Medianizer storage #155

merged 27 commits into from
Jun 24, 2020

Conversation

yaoandrew
Copy link
Contributor

Ended up cherry picking a few commits to make this new branch instead of a crazy rebase on #141

Copy link
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration timestamp needs updating after #145 was merged

go.sum Outdated Show resolved Hide resolved
environments/docker.toml Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - all comments non-blocking 👍

transformers/storage/median/repository.go Outdated Show resolved Hide resolved
transformers/storage/median/repository.go Outdated Show resolved Hide resolved
transformers/storage/median/repository.go Outdated Show resolved Hide resolved
transformers/storage/median/repository.go Outdated Show resolved Hide resolved
transformers/storage/median/repository.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
Replace panic with error

address more feedback
@yaoandrew yaoandrew merged commit 582c7e6 into staging Jun 24, 2020
@yaoandrew yaoandrew deleted the medianizer-storage branch June 24, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants