Merge pull request #100 from makerdao/add-type-for-storage

Add type for median storage
makerdao · Jun 2, 2020 · 37df39e · 37df39e
2 parents 3f6afb7 + 93c5b72
commit 37df39e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/libraries/shared/storage/decoder.go b/libraries/shared/storage/decoder.go
@@ -32,6 +32,8 @@ func Decode(diff types.PersistedDiff, metadata types.ValueMetadata) (interface{}
 	switch metadata.Type {
 	case types.Uint256:
 		return decodeInteger(diff.StorageValue.Bytes()), nil
+	case types.Uint8:
+		return decodeInteger(diff.StorageValue.Bytes()), nil
 	case types.Uint32:
 		return decodeInteger(diff.StorageValue.Bytes()), nil
 	case types.Uint48:

diff --git a/libraries/shared/storage/decoder_test.go b/libraries/shared/storage/decoder_test.go
@@ -38,6 +38,17 @@ var _ = Describe("Storage decoder", func() {
 		Expect(result).To(Equal(big.NewInt(0).SetBytes(fakeInt.Bytes()).String()))
 	})
 
+	It("decodes uint8", func() {
+		fakeInt := common.HexToHash("0000000000000000000000000000000000000000000000000000000000000244")
+		diff := types.PersistedDiff{RawDiff: types.RawDiff{StorageValue: fakeInt}}
+		metadata := types.ValueMetadata{Type: types.Uint8}
+
+		result, err := storage.Decode(diff, metadata)
+
+		Expect(err).NotTo(HaveOccurred())
+		Expect(result).To(Equal(big.NewInt(0).SetBytes(fakeInt.Bytes()).String()))
+	})
+
 	It("decodes uint128", func() {
 		fakeInt := common.HexToHash("0000000000000000000000000000000000000000000000000000000000011123")
 		diff := types.PersistedDiff{RawDiff: types.RawDiff{StorageValue: fakeInt}}

diff --git a/libraries/shared/storage/types/value.go b/libraries/shared/storage/types/value.go
@@ -22,6 +22,7 @@ type ValueType int
 
 const (
 	Uint256 ValueType = iota
+	Uint8
 	Uint32
 	Uint48
 	Uint128