(VDB-1046) Add command to extract diffs #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman and
Gslaughl
- Isolate diff extraction from transformers etc
rmulhol
force-pushed
the
vdb-1046-extract-diffs-cmd
branch
from
744bd8e
to
bc2ea7d
Compare
Gslaughl
approved these changes
Jan 21, 2020
| @@ -20,9 +20,9 @@ import ( | |||
| "math/rand" | |||
|
|
|||
| "github.com/ethereum/go-ethereum/common" | |||
| storage_factory "github.com/makerdao/vulcanizedb/libraries/shared/factories/storage" | |||
| "github.com/makerdao/vulcanizedb/libraries/shared/factories/storage" | |||
| err := extractor.ExtractDiffs() | ||
|
|
||
| Expect(err).To(HaveOccurred()) | ||
| Expect(err).To(MatchError(fakes.FakeError)) |
There was a problem hiding this comment.
Tiny nitpick, but do we need both of these assertions?
There was a problem hiding this comment.
We probably don't need both, but I'm a fan because of the clearer failure message (expected err to have occurred, got none vs expected nil to equal "Failed"). Not super wedded to this, but I think I'd opt for a more comprehensive approach if we decide to minimize our assertions throughout the test suites
There was a problem hiding this comment.
Nice, yeah I agree that isn't a very good test failure if the error didn't occur. Especially if we're using this pattern elsewhere I def have no problem leaving it like this
| } | ||
|
|
||
| type StorageQueue struct { | ||
| type queue struct { |
elizabethengelman
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
storagepackage to avoid import cycles (e.g.datastoreimportingstorageand vice versa). Not a huge fan of having a package namedtypessince it overloads geth, but also not wanting to go down too deep a rabbit hole until we're restructuring things more broadly.staging.