Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation warning update #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Orob-Maslow
Copy link

Motivated by many users wondering why their systems have crashed upwards, or hit the floor for no reason when trying to use the Z axis for the first time, it is important that we try to prevent these user errors that can be avoided. Added warning to calibration doc and calibration first page to remind users if this is the first use, they need to reset the chains and shuttle the sled before attempting calibration. The only hesitation I have is I have not done this with a Mega yet, so I'm unsure if this should be Due specific information or both mega and due suggested actions.

Added example description in events doc to remind users that regardless of makerverse folder name, the system references the base makerverse folder internally as makerverse and the files are then under the events folder, so it will always look like ~/makerverse/events/scriptfilename from the event dialog window where you enter the script

Added warning to calibration doc and calibration first page to remind users if this is the first use, they need to reset the chains and shuttle the sled before attempting calibration
Added example description in events doc to remind users that regardless of makerverse folder name, the system references the base makerverse folder internally as makerverse and the files are then under the events folder, so it will always look like ~/makerverse/events/scriptfilename
@@ -30,5 +30,5 @@ nav_order: 4
## Creating an Event

- Go to Settings -> Events and press "+ Add"
- To run scripts, use a "system" trigger and follow the [commands](/features/commands/) instructions.
- To run scripts, use a "system" trigger and follow the [commands](/features/commands/) instructions. The event scripts reside in the events folder under the base makerverse folder and regardless of the makerverse folder name, the path to get to the event is ~/makerverse/events/scriptname.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: please use backticks to indicate code: ~/makerverse/events/scriptname.

Do a **pre-flight check**.
!!! WARNING !!!

- If this is the *first* use of your maslow, before you do anything, reset the chains !!! Even if the sled is not exactly in the middle, to establish a baseline location, reset the chains. Once that is complete, the sled should respond to the shuttle commands to move so then you can avoid costly disaster or erratic behavior. As with all new equipment, please make power shutoff to the system accessible in case you must shut it off quickly. In the makerverse, the RESET button will cut power to the motors, so keep that in mind. After calibration, the sled will be properly positioned and allow future chain resets to occur with chain marks to reset back to the middle of the work piece.
Copy link
Contributor

@zaneclaes zaneclaes Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware that this is done automatically during the calibration process? When you get to the Chains tab, Makerverse will perform a reset chains implicitly as you complete that flow.

If that's still a concern, I could make the New Machine? modal do this automatically, as well.

My thinking, here, is that this is not the sort of problem which should require documentation. Rather, this sort of problem should be solved by the software. If the user needs to find the docs in order to avoid shooting themselves in the foot, the software is deficient.

<br/>
-- DAMAGE MAY OCCUR --
<br/>
If this is the first use of your system and you have not yet tested sled movement please close this window and reset your chains.
Copy link
Contributor

@zaneclaes zaneclaes Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This screen already performs a Reset Chains before it ever attempts to move the sled (or, it should do so). It would be redundant to close the modal and do so yourself.

<br/>
If this is the first use of your system and you have not yet tested sled movement please close this window and reset your chains.
<br />
Please run a pre-flight check before attempting to calibrate.
Copy link
Contributor

@zaneclaes zaneclaes Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a warning about this which you need to click "Okay" for before you can ever see this screen... try opening the calibration modal in version 1.1.2 and you'll see what I mean.

@zaneclaes
Copy link
Contributor

zaneclaes commented Oct 31, 2020

Thanks for the PR, @Orob-Maslow! I appreciate the help with the docs. However, I just want to make sure that this isn't redundant against the new workspace + Welcome! dialogs in version 1.1.2. Many of the things you added to the docs are now already done by the software itself.

I'm generally of the opinion that "big, scary warnings" in the docs indicate that the software doesn't have enough guard-rails to protect the user. So if there's a way I can fix these "gochas" with code rather than docs, I'd prefer that...

@Orob-Maslow
Copy link
Author

I agree with your assessment and most of my input was based on experience with 1.1.1g (I believe). If this pull is stale, we can kill it if the meat of it has been addressed, which ultimately was the goal. Thanks for your efforts.

@Orob-Maslow
Copy link
Author

And today another user destroyed their ring on the sled. Maybe we should make better defaults in the firmware so Maslow Due doesn't have to be homed in order to be jogged without going nuts since a written warning that must be read probably isn't the best approach.

@zaneclaes
Copy link
Contributor

zaneclaes commented Nov 26, 2020

What firmware were they using? I already tried to improve the defaults on the Due firmware. Since my updates a couple months ago, it attempts to default to thinking the sled is in the middle of the stock. But this assumes a standard frame build. And if there’s anything in the EEPROM, all bets are off.

Also, Makerverse 1.1.2 asks you if it’s a newly flashed machine and performs a homing when you create the workspace. So I’m confused how this happened... you can’t skip the screen, you have to answer the question. So they would have had to explicitly answer incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants