Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support faulhaber #222

Merged
merged 14 commits into from
May 1, 2020
Merged

Support faulhaber #222

merged 14 commits into from
May 1, 2020

Conversation

pi-r-p
Copy link
Collaborator

@pi-r-p pi-r-p commented Apr 29, 2020

Support for Faulhaber motors

@jabby
Copy link
Member

jabby commented Apr 29, 2020

FYI when we will be able to merge this, we will need to update the sonar analysis.
Actually there is one analysis for the following firmware versions. https://github.com/makers-for-life/makair/tree/master/src/software/firmware#sonar-analysis

I can do that for you. @pi-r-p ping me when you need my contribution on this PR.

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
38.3% 38.3% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
37.7% 37.7% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
38.3% 38.3% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
38.3% 38.3% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
37.7% 37.7% Duplication

@dsferruzza dsferruzza merged commit 85334a8 into master May 1, 2020
@dsferruzza dsferruzza deleted the supportFaulhabber branch May 1, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabby jabby jabby left review comments

@dsferruzza dsferruzza Awaiting requested review from dsferruzza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pi-r-p @jabby @dsferruzza