Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove software #234

Merged
merged 2 commits into from
May 8, 2020
Merged

Remove software #234

merged 2 commits into from
May 8, 2020

Conversation

dsferruzza
Copy link
Member

This shall act the repo split.

Did I miss something?

eliottvincent
eliottvincent reviewed May 8, 2020
View reviewed changes
Copy link
Member

@eliottvincent eliottvincent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd go a step further and remove the ./src/software dir.

@dsferruzza
Copy link
Member Author

Looks good, I'd go a step further and remove the ./src/software dir.

I let it and its subfolders so that I could let nice messages to redirect people where they might have bookmarks/history. I believe it is better this way, until there is nothing left but documentation in the repo.

@valeriansaliou valeriansaliou merged commit 5721b9d into master May 8, 2020
@valeriansaliou valeriansaliou deleted the remove-software branch May 8, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliottvincent eliottvincent eliottvincent left review comments

@valeriansaliou valeriansaliou valeriansaliou approved these changes

@jabby jabby Awaiting requested review from jabby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsferruzza @valeriansaliou @eliottvincent