Stevie's frontend challenge (incomplete) #119
Conversation
…ode, need to implement callbacks
…ent user-input capability
| @@ -0,0 +1,167 @@ | |||
| (() => { | |||
There was a problem hiding this comment.
I believe is good practice to .gitignore this file to avoid conflicts if working in a team. This file will anyway be autogenerated when running 'npm run build' locally
| setChits(chits) { | ||
| this.reset(); | ||
| chits.forEach((chit) => this.chits.push(`${chit.user.handle}: ${chit.body}`)); | ||
| } |
There was a problem hiding this comment.
It might be easier to store everything that comes from the server into the chits array (including body, user, time, likes,...) and then, when displaying what you want to display, select what you want. In that case, this method could have just been something like this.chits = chits
| @@ -0,0 +1,61 @@ | |||
| class ChitterView { | |||
There was a problem hiding this comment.
View methods are well explained and should work for using the page locally. It is missing the API interface
| document.querySelectorAll('.chit').forEach(chit => { | ||
| chit.remove(); | ||
| }); |
There was a problem hiding this comment.
As a refactor suggestion, this could have been a separate method
| const chitEl = document.createElement('div') | ||
| chitEl.innerText = chit | ||
| chitEl.className = 'chit'; | ||
| this.maincontainerEl.append(chitEl); |
There was a problem hiding this comment.
Also separate this in a different method could look nice
| @@ -0,0 +1,33 @@ | |||
| class ChitterModel { | |||
There was a problem hiding this comment.
Good. I think the model does what it is suppose to do and names are clear enough to be understood from someone who didn't write the code
| headers: { | ||
| "Content-Type": 'application/json' | ||
| }, | ||
| body: (`{"user": {"handle":"${username}", "password":"${password}"}}`) |
There was a problem hiding this comment.
doesn't need stringify because I've already added all the quotes to turn things into strings
No description provided.