39 out 41 #210
Open
39 out 41 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 25, 2017
| @@ -208,12 +251,28 @@ def your_birthday_is_on_a_friday_in_the_year(birthday) | |||
| # and 1 that is 4 letters long. Return it as a hash in the format | |||
| # word_length => count, e.g. {2 => 1, 3 => 5, 4 => 1} | |||
| def count_words_of_each_length_in_a_file(file_path) | |||
| result = Hash.new 0 | |||
| lines = File.readlines(file_path) | |||
| words = lines.map(&:split).flatten.map { |words| words.gsub(/\W/, "") } | |||
There was a problem hiding this comment.
Shadowing outer local variable - words.
| @@ -200,6 +239,10 @@ def is_a_2014_bank_holiday?(date) | |||
| # e.g. january 1st, will next be a friday in 2016 | |||
| # return the day as a capitalized string like 'Friday' | |||
| def your_birthday_is_on_a_friday_in_the_year(birthday) | |||
| until birthday.friday? do | |||
| birthday += 31536000 | |||
There was a problem hiding this comment.
Use underscores(_) as decimal mark and separate every 3 digits with them.
| end | ||
|
|
||
| # remove instances of nil AND false from an array | ||
| def remove_nils_and_false_from_array(array) | ||
| array.select { |item| !!item } |
There was a problem hiding this comment.
Use reject instead of inverting select.
| end | ||
|
|
||
| # remove instances of nil (but NOT false) from an array | ||
| def remove_nils_from_array(array) | ||
| array.select { |item| !item.nil? } |
There was a problem hiding this comment.
Use reject instead of inverting select.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.