Petra's Ruby refresher #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 19, 2017
lib/questions.rb
Outdated
| end | ||
|
|
||
| # get the domain name *without* the .com part, from an email address | ||
| # so alex@makersacademy.com becomes makersacademy | ||
| def get_domain_name_from_email_address(email) | ||
| ((email.split("@"))[1].split("."))[0] |
There was a problem hiding this comment.
Don't use parentheses around a method call.
lib/questions.rb
Outdated
| end | ||
|
|
||
| # take out all the capital letters from a string | ||
| # so 'Hello JohnDoe' becomes 'ello ohnoe' | ||
| def remove_capital_letters_from_string(string) | ||
| string.gsub!(/[A-Z]/,"") |
lib/questions.rb
Outdated
| end | ||
|
|
||
| # get the average from an array, rounded to the nearest integer | ||
| # so [10, 15, 25] should return 17 | ||
| def average_of_array(array) | ||
| (array.reduce(:+)/array.size.to_f).ceil |
There was a problem hiding this comment.
Surrounding space missing for operator /.
lib/questions.rb
Outdated
| end | ||
|
|
||
| # add up all the numbers in an array, so [1, 3, 5, 6] | ||
| # returns 15 | ||
| def total_of_array(array) | ||
| sum = 0 | ||
| array.each { |number| sum += number} |
lib/questions.rb
Outdated
| end | ||
|
|
||
| # count the numbers of elements in an element which are palindromes | ||
| # a palindrome is a word that's the same backwards as forward | ||
| # e.g. 'bob'. So in the array ['bob', 'radar', 'eat'], there | ||
| # are 2 palindromes (bob and radar), so the method should return 2 | ||
| def number_of_elements_that_are_palindromes(array) | ||
| array.select { |word| word == word.reverse}.count |
lib/questions.rb
Outdated
| end | ||
|
|
||
| # sort an array of words by their last letter, e.g. | ||
| # ['sky', 'puma', 'maker'] becomes ['puma', 'maker', 'sky'] | ||
| def array_sort_by_last_letter_of_word(array) | ||
| array.sort_by { |word| word[-1]} |
lib/questions.rb
Outdated
| end | ||
|
|
||
| # remove instances of nil AND false from an array | ||
| def remove_nils_and_false_from_array(array) | ||
| array.reject { |word| word == nil || word == false} |
There was a problem hiding this comment.
Prefer the use of the nil? predicate.
Space missing inside }.
lib/questions.rb
Outdated
| end | ||
|
|
||
| # remove instances of nil (but NOT false) from an array | ||
| def remove_nils_from_array(array) | ||
| array.reject { |word| word == nil} |
There was a problem hiding this comment.
Prefer the use of the nil? predicate.
Space missing inside }.
lib/questions.rb
Outdated
| end | ||
|
|
||
| # keep only the elements that start with a vowel | ||
| def select_elements_starting_with_vowel(array) | ||
| array.select { |word| word =~ /^[aeiou]/i} |
lib/questions.rb
Outdated
| @@ -1,152 +1,194 @@ | |||
| # keep only the elements that start with an a | |||
| def select_elements_starting_with_a(array) | |||
| array.select { |word| word[0] == "a"} | |||
houndci-bot
reviewed
Aug 19, 2017
| end | ||
|
|
||
| # return true if the date is a uk bank holiday for 2014 | ||
| # the list of bank holidays is here: | ||
| # https://www.gov.uk/bank-holidays | ||
| def is_a_2014_bank_holiday?(date) | ||
| bank_holidays = [Time.new(2014, 12, 26), Time.new(2014, 12, 25), Time.new(2014, 8, 25), Time.new(2014, 5, 26), Time.new(2014, 5, 5), Time.new(2014, 4, 21), Time.new(2014, 4, 18), Time.new(2014, 1, 1)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.