fix: unknown features should checked against all possible features

makesjs · Jun 13, 2022 · 40d8732 · 40d8732
1 parent 3e75706
commit 40d8732
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/run-questionnaire.js b/lib/run-questionnaire.js
@@ -92,11 +92,20 @@ async function run(questions, {
     }
   }
 
+  const allPossibleFeatures = [];
   for (let i = 0, ii = questions.length; i < ii; i++) {
-    await ask(questions[i]);
+    const q = questions[i];
+    if (q.choices) {
+      q.choices.forEach(choice => {
+        if (choice.value) {
+          allPossibleFeatures.push(choice.value);
+        }
+      });
+    }
+    await ask(q);
   }
 
-  const unknownFeatures = minusSet(preselectedFeatures, pickedFeatures);
+  const unknownFeatures = minusSet(preselectedFeatures, allPossibleFeatures);
 
   return [
     {...predefinedProperties, ...properties},

diff --git a/test/run-questionnaire.spec.js b/test/run-questionnaire.spec.js
@@ -280,7 +280,7 @@ test('run runs through questionnaire with preselectedFeatures and predefinedProp
 
 test('run runs through questionnaire with preselectedFeatures and predefinedProperties, and keeps unknown properties and selection', async t => {
   const result = await run(questions, {
-    preselectedFeatures: ['postcss', 'lorem', 'abc', 'lorem'],
+    preselectedFeatures: ['webpack', 'dumber', 'postcss', 'lorem', 'abc', 'lorem'],
     predefinedProperties: {name: 'new-app', foo: 'bar'},
     _debug: [2]
   });