Slot control #168
Merged
Slot control #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRD-356 Implement Slot control
After the findings in ENG-280 the implementation will be reduced in scope so that it doesn't have to work with the List and Shape controls. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d9be605 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
migueloller
force-pushed
the
miguel/prd-356-slot
branch
from
705568a
to
a14ad2c
Compare
migueloller
force-pushed
the
miguel/prd-356-slot
branch
from
a14ad2c
to
b350e45
Compare
migueloller
force-pushed
the
miguel/prd-356-slot
branch
from
b350e45
to
ec9bc25
Compare
migueloller
force-pushed
the
miguel/prd-356-slot
branch
from
ec9bc25
to
a3bd336
Compare
migueloller
force-pushed
the
miguel/prd-356-slot
branch
from
a3bd336
to
d9be605
Compare
|
|
||
| const isServer = typeof window === 'undefined' | ||
| const useInsertionEffectSpecifier = 'useInsertionEffect' | ||
| // @ts-expect-error: React types are outdated. |
|
I did review this. Going in commit order really helped! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.